-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Svelte 5 runes support #59
Conversation
Added export from types file, as it can be useful when working around the package. |
Would using the new syntax break the backward compatibility for people using the previous Svelte versions? |
From what I found, it seems like yes. Maybe you can publish as an With the latest version of the package, svelte shows a lot of warnings on the console that some of the reactive statements won't work because they are not supported anymore by Svelte 5. |
Oh ok, I didn't know that. Then it totally makes sense to publish this update as a new major version. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is obfuscated code?Obfuscated files are intentionally packed to hide their behavior. This could be a sign of malware. Packages should not obfuscate their code. Consider not using packages with obfuscated code. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Thank you very much @rtrampox |
Refactor code in favor of new svelte 5 runes syntax.
CropperProps
type that describes all the component props.$
syntax to$effect()
and$state()
for runes mode support.